[BUGFIX beta] Ensure closure actions are wrapped in a run loop. #12519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in Ember core team meeting on 2015-10-23.
rwjblue
added a commit
that referenced
this pull request
Oct 24, 2015
[BUGFIX beta] Ensure closure actions are wrapped in a run loop.
|
👍 I'm surprised I didn't hit that earlier. |
rwjblue
added a commit
to rwjblue/ember-route-action-helper
that referenced
this pull request
Feb 5, 2016
This was implemented in the normal `(action` helper in emberjs/ember.js#12519.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Ember core team meeting on 2015-10-23.